Fix master CI: apt-get update, webpack 5.110 sideEffects regression, jest teardown race - #489
Merged
Merged
Conversation
The build jobs install from the runner image's stale package index, so once security.ubuntu.com rotates a .deb version the fetch 404s and all 16 jobs fail before npm install. The Lint job already updates first.
three@0.128 declares sideEffects: false, but examples/js scripts attach to the THREE global; webpack 5.110 started trusting the declaration and dropped the OrbitControls require from the bundle.
If the browser closes while a console handler is still awaiting getProperty, the rejection is unhandled and fatal on Node 24, killing jest before it can report the test result.
u9g
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master CI currently fails on every PR for three stacked environmental reasons; this bundles the three small fixes (all previously validated on the green #484 run):
apt-get update, unlike Lint), so rotated .deb versions 404 beforenpm installruns. Fix:sudo apt-get update &&first.THREE.OrbitControls is not a constructor— fresh installs pull webpack 5.110.x, which now honorsthree@0.128.0's incorrectsideEffects: falseand drops the barerequire('three/examples/js/controls/OrbitControls')from the bundle, blanking every render. Fix: asideEffects: truemodule rule forthree/examples/jsin the index config.arg.getProperty('message')rejects if the browser closes mid-await; on Node 24 the unhandled rejection kills jest before it reports results. Fix: catch the rejection.Verified end to end on the #484 run equivalents; with only fix 1 the jobs get past install and fail on 2/3, e.g. build (1.18.1) here.