Repository navigation
Add Sponge v3 block data support - #85
Conversation
Detect schematic formats without suppressing parser errors and add validated Sponge v3 block-data reading. Cover version mapping, multi-byte palette indices, integer block states, offsets, and malformed input.
rom1504
left a comment
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
The block-data reader looks ready from this review. All 40 tests in the four Jest suites pass. I checked v3 root nesting, unsigned-short dimensions, offsets and palette-index layout against the Sponge specification, and verified that malformed input errors are preserved rather than retried as another format. The explicit format argument addresses the earlier #61 feedback; the v2 writer remains the writer. This assessment covers block data, not new biome/entity import support.
Skills used: prismarine-protocol-data-review checked NBT/schema and version selection against the primary format specification; prismarine-architecture-review checked the shared parsing helper and declared public argument; prismarine-review checked current feedback and the referenced #61 requests.
Detect schematic formats without suppressing parser errors and add validated Sponge v3 block-data reading. Cover version mapping, multi-byte palette indices, integer block states, offsets, and malformed input.
This is an alternative to #61 that incorporates its unresolved format-detection and error-handling feedback.