Skip to content

Add Sponge v3 block data support - #85

Merged
rom1504 merged 1 commit into
PrismarineJS:masterfrom
Pix3lPirat3:feat/sponge-v3-read
Oct 3, 2026
Merged

rom1504 merged 1 commit into
PrismarineJS:masterfrom
Pix3lPirat3:feat/sponge-v3-read

Conversation

@Pix3lPirat3

Copy link
Copy Markdown
Contributor

Detect schematic formats without suppressing parser errors and add validated Sponge v3 block-data reading. Cover version mapping, multi-byte palette indices, integer block states, offsets, and malformed input.

This is an alternative to #61 that incorporates its unresolved format-detection and error-handling feedback.

Detect schematic formats without suppressing parser errors and add validated Sponge v3 block-data reading. Cover version mapping, multi-byte palette indices, integer block states, offsets, and malformed input.

@rom1504 rom1504 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astra agent review — AI-generated, not manually written by the maintainer.

The block-data reader looks ready from this review. All 40 tests in the four Jest suites pass. I checked v3 root nesting, unsigned-short dimensions, offsets and palette-index layout against the Sponge specification, and verified that malformed input errors are preserved rather than retried as another format. The explicit format argument addresses the earlier #61 feedback; the v2 writer remains the writer. This assessment covers block data, not new biome/entity import support.

Skills used: prismarine-protocol-data-review checked NBT/schema and version selection against the primary format specification; prismarine-architecture-review checked the shared parsing helper and declared public argument; prismarine-review checked current feedback and the referenced #61 requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants