test: select the version under test with MC_VERSION instead of a title grep - #1526
Open
u9g wants to merge 1 commit into
Open
test: select the version under test with MC_VERSION instead of a title grep#1526u9g wants to merge 1 commit into
u9g wants to merge 1 commit into
Conversation
…e grep CI ran mochaTest with -g <version>v, so a suite only ran if its title carried a Minecraft version. The three suites that are not version-parameterised, declare_commands handling, lpVec3 and ping, never ran in any job. The version loops now read the list from test/common/testedVersions, which honours MC_VERSION and rejects a value that is not a supported version, so CI selects the version without touching test titles and every suite runs in every job. Running mocha with no MC_VERSION still tests every supported version. declare_commands handling fails until PrismarineJS#1527 lands, which is the tree fix this filter was hiding.
u9g
force-pushed
the
test/select-version-without-grep
branch
from
September 7, 2026 01:03
7f23000 to
80bc3b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invariants of the test run:
MC_VERSIONnames the one supported version the version-parameterised suites run against; unset runs all of them.MC_VERSIONthat is not insupportedVersionsfails the run instead of quietly testing nothing.CI ran
mochaTest -- -g <version>v, so a suite only ran if its title carried a Minecraft version.declare_commands handling,lpVec3andpinghave never run in any job.Depends on #1527:
declare_commands handlingis the suite this filter was hiding, and it fails until that tree fix lands.Checked locally:
MC_VERSION=1.21.4selects the 1.21.4 suites plus the three unversioned ones,MC_VERSION=9.9.9fails with the supported list, andlpVec3andpingpass.