checksum last seen messages in acknowledgement order - #1521
Open
Pix3lPirat3 wants to merge 2 commits into
Open
Conversation
Use the circular buffer's logical traversal for both acknowledgement bits and the checksum so wrapped chat histories stay synchronized with the server.
extremeheat
reviewed
Sep 6, 2026
extremeheat
left a comment
extremeheat
left a comment
Member
There was a problem hiding this comment.
Cool, did you test against the server side impl also? We implement both sides
…t logic added a loopback integration test using node-minecraft-protocol's real server and client. It rotates the 20-message history, sends a standalone acknowledgement, verifies that a correctly checksummed/signed message is accepted, then changes only the next checksum and verifies that the server rejects it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the circular buffer's logical traversal for both acknowledgement bits and the checksum so wrapped chat histories stay synchronized with the server.