test(nether): wait for the overworld chunks after the return portal - #4055
Open
u9g wants to merge 1 commit into
Open
test(nether): wait for the overworld chunks after the return portal#4055u9g wants to merge 1 commit into
u9g wants to merge 1 commit into
Conversation
Contributor
|
Tests more than 1.5x slower than master (durations are noisy, so this is informational): |
Member
|
CI fails |
The return leg only awaited the spawn event. The respawn lands the bot at origin, so the per-test reset takes the no-teleport path and never calls waitForChunksToLoad. On a slow runner the overworld spawn column arrived after the next tests had already started, so placeBlock got a null reference block on 1.14.4 (all four attempts in run 33949373493, since mocha's retries re-run instantly against the same empty world). Wait for the chunks on the way back, as the outbound leg already does.
u9g
force-pushed
the
test/nether-return-chunk-wait
branch
from
September 5, 2026 19:13
c41dae4 to
ce3848f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nether test's return leg only awaited the
spawnevent. The respawn lands the bot exactly at origin, soresetStatetakes its no-teleport path and never callswaitForChunksToLoad. On a slow runner the overworld spawn column arrives after the following tests have already started; in run 33949373493 the 1.14.4 trace shows the position packet, thenparticlesand all fourplaceBlockattempts inside ~60ms, and only then themap_chunkfor 0,0.bot.blockAtreturned null for the reference block on every attempt, since mocha's retries re-run instantly against the same empty world.Wait for the chunks on the way back, as the outbound leg already does.
waitForChunksToLoadis a no-op when the columns are present, so normal runs pay nothing.Ran
netherandplaceBlock emits blockPlacedlocally on 1.8.8, 1.14.4 and 1.21.8: all pass.