test: connect the bot only after the nether forceload has finished - #4050
Closed
u9g wants to merge 1 commit into
Closed
test: connect the bot only after the nether forceload has finished#4050u9g wants to merge 1 commit into
u9g wants to merge 1 commit into
Conversation
The warm-up forceload blocks the server's main thread until all 49 nether
chunks are FULL. Status pings are answered off-thread, so pingUntilReady
resolved while the main thread was still generating, and the bot connected
into a server that could not process its login. When generation took more
than 30s the login-phase connection hit netty's ReadTimeoutHandler(30) and
the whole version failed in the before-all hook ("lost connection: Timed
out" on the GameProfile). CI hit this three times on 1.16.5-1.19.3 with
30.9-32.3s stalls; versions where the stall stayed near 20s passed.
Wait for the console's "Marked N chunks in minecraft:the_nether" line as
well as the ping before begin(), so no connection exists while the main
thread is blocked. Versions without the execute command skip the wait.
Contributor
|
Tests more than 1.5x slower than master (durations are noisy, so this is informational): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4037 (
test/cheap-nether-gen); fixes the failure that has made its CI red three times.Why #4037 fails
The warm-up
forceloadblocks the server's main thread until all 49 nether chunks are FULL. Status pings are answered off-thread, sopingUntilReadyresolves while the main thread is still generating, and the bot connects into a server that cannot process its login. Netty'sReadTimeoutHandler(30)runs on the IO thread, so a login-phase connection that has sentlogin_startand heard nothing for 30s is dropped regardless of what the main thread is doing. Whether a version fails is just whether the stall crosses 30s on that runner:GameProfile ... lost connection: Timed out, before-all hook failsChange
test/externalTest.jswaits for the console'sMarked N chunks in minecraft:the_nether ... to be force loadedline as well as the ping beforebegin(), so no connection exists while the main thread is blocked. Versions without the execute command (pre-1.14) skip the wait and are unchanged. The stall still lands inside the hook's budget, as #4037 intended.Verification
Local, nether test only, with another server running on the same box:
The log order is now
Marked 49 chunks->pong->starting boton every forceload version.