Skip to content

Repeat duration regressions at the end of compareDurations output - #4033

Closed
u9g wants to merge 1 commit into
masterfrom
compare-durations-summary-at-end
Closed

Repeat duration regressions at the end of compareDurations output#4033
u9g wants to merge 1 commit into
masterfrom
compare-durations-summary-at-end

Conversation

@u9g

@u9g u9g commented Aug 31, 2026

Copy link
Copy Markdown
Member

compareDurations.js printed its regression summary with console.error. GitHub Actions interleaves stderr out of order with buffered stdout, so in a long job (e.g. this run, ~4900 lines) the 1 test(s) got more than 1.5x slower than master line landed mid-table, the single SLOWER row was hundreds of lines further up, and the step log ended with unmarked duration rows followed by Process completed with exit code 1 — no indication of what failed without searching the log.

Now the regressed rows are collected and printed again with the summary at the very end, on stdout, so the final lines of a failing step are exactly the tests that regressed:

1 test(s) got more than 1.5x slower than master:
  SLOWER    1644ms ->   16107ms  mineflayer_external 1.16.5v spawnEvent

CI-tooling only, no bot behaviour change; both exit paths exercised locally with fixture duration files.

@u9g
u9g force-pushed the compare-durations-summary-at-end branch from d3170fc to 23fd365 Compare September 4, 2026 18:17
The summary went to stderr, which GitHub Actions interleaves out of
order with buffered stdout: in a ~4900-line job log the 'N test(s) got
slower' line landed mid-table and the log ended with unmarked duration
rows plus 'exit code 1'. Collect the SLOWER lines and print them again
with the summary, on stdout, so the final lines of the step say exactly
which tests regressed.
@u9g
u9g force-pushed the compare-durations-summary-at-end branch from 23fd365 to c7efb28 Compare September 4, 2026 21:13
@u9g u9g closed this Sep 6, 2026
@u9g
u9g deleted the compare-durations-summary-at-end branch September 6, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant