Skip to content

fix: only set isAlive to false on death respawn, not dimension change #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnonymoDGH wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: only set isAlive to false on death respawn, not dimension change #3967

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
018b181
fix: only set isAlive to false on death respawn, not dimension change…
AnonymoDGH Aug 16, 2026
44bd87e
fix: re-emit spawn on dimension change respawn while keeping isAlive …
AnonymoDGH Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions lib/plugins/health.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,26 @@ module.exports = inject

function inject (bot, options) {
bot.isAlive = true
// Set when a dimension-change respawn is received so that the next
// update_health packet re-emits spawn, matching the timing used for deaths.
let spawnAfterDimensionChange = false

bot._client.on('respawn', (packet) => {
bot.isAlive = false
// The respawn packet is sent both on death and on dimension change. The
// copyMetadata (Data To Keep) field is false on death and true when the
// player is simply moving between dimensions. On a real death, mark the
// bot dead so the next update_health re-emits spawn. On a dimension change
// the bot is still alive, so keep isAlive true (so physics keeps updating
// its position, see #3905) and schedule a spawn event for the next
// update_health, since consumers (and the nether test) expect spawn to
// fire when the bot re-enters a world. On versions before 1.16.1 the field
// is absent (undefined), which keeps the previous always-false behaviour.
if (packet.copyMetadata) {
bot.isAlive = true
spawnAfterDimensionChange = true
} else {
bot.isAlive = false
}
bot.emit('respawn')
})

Expand All @@ -26,8 +43,9 @@ function inject (bot, options) {
}
if (!options.respawn) return
bot.respawn()
} else if (bot.health > 0 && !bot.isAlive) {
} else if (bot.health > 0 && (!bot.isAlive || spawnAfterDimensionChange)) {
bot.isAlive = true
spawnAfterDimensionChange = false
bot.emit('spawn')
}
})
Expand Down
Loading