fix(ray_trace): don't treat zero yaw/pitch as missing in blockAtEntityCursor - #3965
Open
AnonymoDGH wants to merge 1 commit into
Open
fix(ray_trace): don't treat zero yaw/pitch as missing in blockAtEntityCursor#3965AnonymoDGH wants to merge 1 commit into
AnonymoDGH wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3935
Problem
bot.blockAtEntityCursor()validated the entity orientation with truthiness checks:Because
0is falsy in JavaScript, a perfectly valid orientation withyaw === 0orpitch === 0(facing due south / looking level) was treated as if the value were missing, and the ray trace was skipped — the function returnednulleven though the entity was correctly oriented.Fix
Validate with
Number.isFiniteinstead of truthiness, so only genuinely missing (null/undefined) or non-finite (NaN/Infinity) values are rejected, while0is accepted:This is equivalent to the issue's proposed two-part
isMissing || isInvalidcheck but in a single condition, and it keeps the existing behavior for all invalid inputs.Verified
yaw=0,pitch=0,yaw=0 && pitch=0, normal values, andheight=0all proceed to the ray trace; missingheight/pitch/yaw,NaN,Infinity, and missingpositionall returnnull.test/externalTests/rayTrace.js(which runs in CI): it builds a small stone wall ahead at eye level, setsyaw = 0andpitch = 0, and assertsblockAtEntityCursorfinds the wall instead of returningnull.standardlint passes on both changed files.