Skip to content

fix(anvil): use the 50 character name limit on 1.17+ #3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnonymoDGH wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(anvil): use the 50 character name limit on 1.17+ #3964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/plugins/anvil.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ module.exports = inject

function inject (bot) {
const Item = require('prismarine-item')(bot.registry)
// The anvil custom name limit was raised from 35 to 50 characters in 1.17
const maxNameLength = bot.supportFeature('anvilNameLengthIsFifty') ? 50 : 35

const matchWindowType = window => /minecraft:(?:chipped_|damaged_)?anvil/.test(window.type)

Expand Down Expand Up @@ -43,7 +45,7 @@ function inject (bot) {
}

async function combine (itemOne, itemTwo, name) {
if (name?.length > 35) err('Name is too long.')
if (name?.length > maxNameLength) err('Name is too long.')
if (bot.supportFeature('useMCItemName')) {
bot._client.registerChannel('MC|ItemName', 'string')
}
Expand All @@ -70,7 +72,7 @@ function inject (bot) {
}

async function rename (item, name) {
if (name?.length > 35) err('Name is too long.')
if (name?.length > maxNameLength) err('Name is too long.')
if (bot.supportFeature('useMCItemName')) {
bot._client.registerChannel('MC|ItemName', 'string')
}
Expand Down
Loading