Repository navigation
pc: enchantment cost coefficients for 1.21.8 - 26.1 from the data pack - #1317
Pix3lPirat3 wants to merge 1 commit into
Conversation
Since the 1.21.8 data minCost / maxCost were computed from the enchantment's min and max level instead of its costs: aqua affinity maxCost 1 instead of 41, binding curse minCost 1 instead of 25, every per-level slope halved. Values now come from the data pack's min_cost / max_cost (a = per_level_above_first, b = base - a) for 1.21.8, 1.21.9 (1.21.10), 1.21.11 and 26.1; 1.21 - 1.21.6 were already right. Generator fix: PrismarineJS/minecraft-data-generator#91
rom1504
left a comment
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
The coefficient-only correction looks ready from this review. All changes are minCost/maxCost a/b values. For all 42/42/43/43 enchantments in 1.21.8, 1.21.9, 1.21.11 and 26.1, those values match the successful native generator #92 artifacts at its current head and the schema’s a × level + b representation. Keep #92 coordinated so regeneration retains the correction.
Skills used: prismarine-protocol-data-review checked the source definition→generator→data formula and version-specific artifacts; prismarine-architecture-review checked the active producer repair; prismarine-review distinguished successful individual jobs from the overall cancelled CI matrix.
Since the 1.21.8 data minCost / maxCost were computed from the enchantment's min and max level instead of its costs: aqua affinity maxCost 1 instead of 41, binding curse minCost 1 instead of 25, every per-level slope halved. Values now come from the data pack's min_cost / max_cost (a = per_level_above_first, b = base - a) for 1.21.8, 1.21.9 (1.21.10), 1.21.11 and 26.1; 1.21 - 1.21.6 were already right.
Generator fix: PrismarineJS/minecraft-data-generator#91
Companion PRs: generated by PrismarineJS/minecraft-data-generator#92 (derive cost coefficients from the definition). Data is committed, so it does not strictly block.