pc/protocol: cookie_response value is optional on 1.21.8 - #1274
Merged
rom1504 merged 1 commit intoSep 7, 2026
Conversation
ServerboundCookieResponsePacket writes the payload with writeNullable on 1.21.8 as on every other version; the schema declared it as a plain ByteArray, so a stored cookie could not be echoed and a null one deserialized as an empty array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packet_common_cookie_response.valueis declared as a plainByteArrayon 1.21.8 only; 1.21.5, 1.21.6, 1.21.9 and later havevalue?: ByteArray. The 1.21.8 client writes it withwriteNullablelike every other version (ServerboundCookieResponsePacket.STREAM_CODEC/write), so a client answering acookie_requestwith a stored cookie serializes it wrong on 1.21.8 and a server-side reader turns vanilla's null into an empty array. Found while adding cookie replies to node-minecraft-protocol (PrismarineJS/node-minecraft-protocol#1522).proto.ymlandprotocol.jsonupdated;tools/jstests pass.