Skip to content

Add a 1.21.4 module - #90

Open
Pix3lPirat3 wants to merge 1 commit into
PrismarineJS:mainfrom
Pix3lPirat3:feat/add-1.21.4-module
Open

Pix3lPirat3 wants to merge 1 commit into
PrismarineJS:mainfrom
Pix3lPirat3:feat/add-1.21.4-module

Conversation

@Pix3lPirat3

@Pix3lPirat3 Pix3lPirat3 commented Sep 18, 2026 •

Copy link
Copy Markdown

1.21.4 was the only release since 1.14 without a module; its data was assembled by hand and carries the 1.21.3 recipes. Copy of 1.21.3 on yarn 1.21.4+build.8 with the API changes: Ingredient.getMatchingItems() returns a stream, FoliageColors exposes constants, and the map-extending recipe (empty result) is skipped. Generates all 16 files.


Companion PRs: regenerated data is in PrismarineJS/minecraft-data#1315.

1.21.4 was the only release since 1.14 without a module; its data was assembled by hand and carries the 1.21.3 recipes. Copy of 1.21.3 on yarn 1.21.4+build.8 with the API changes: Ingredient.getMatchingItems() returns a stream, FoliageColors exposes constants, and the map-extending recipe (empty result) is skipped. Generates all 16 files.

@rom1504 rom1504 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astra agent review — AI-generated, not manually written by the maintainer.

No blocking issue found in the new module. I compared it with 1.21.3: the differences are the version/Yarn mapping, stream-based ingredient access, foliage constants and empty-result guard. The exact-head Build 1.21.4 job succeeded and produced all 16 JSON files. I downloaded its data-1.21.4 artifact and verified that recipes.json is structurally identical to minecraft-data#1315. All 1,568 of those recipes match official 1.21.4 recipe inputs and result IDs/counts and load through prismarine-recipe.

The overall workflow was cancelled in other matrix entries; the evidence above is specifically the successful 1.21.4 job and its artifact. I have not independently regenerated every output locally, or established full semantic equivalence for all 16 categories.

Skills used: prismarine-protocol-data-review checked mapped API changes, exact-head generated output and the data consumer; prismarine-architecture-review checked the existing per-version module/discovery boundary; prismarine-review checked current code and discussion and kept the validation scope explicit.

@rom1504 rom1504 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astra agent review — AI-generated, not manually written by the maintainer.

The new module’s scoped code/data review still holds: the successful exact-head 1.21.4 artifact emits all 16 categories, and its recipes match data #1315. See the existing review for the native recipe and consumer evidence.

The refreshed overall matrix now records failed Build 1.17 and 1.18 jobs. Those remain an integration prerequisite to diagnose or rerun; the successful new-module result is not a full-matrix pass. No additional code finding or new local generation run in this publication pass.

Skills used: prismarine-review checked the current revision and discussion; prismarine-protocol-data-review checked the version-selected producer/consumer contract; prismarine-architecture-review checked package ownership and integration scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants