Skip to content

Fix item display-name extraction for 1.11.2 and 1.12.2 - #84

Open
Pix3lPirat3 wants to merge 2 commits into
PrismarineJS:mainfrom
Pix3lPirat3:fix/legacy-item-display-names
Open

Pix3lPirat3 wants to merge 2 commits into
PrismarineJS:mainfrom
Pix3lPirat3:fix/legacy-item-display-names

Conversation

@Pix3lPirat3

Copy link
Copy Markdown

Use native item-stack display names instead of translating bare keys.

The 1.11.2 and 1.12.2 item generators translate bare keys such as tile.stone, producing translation keys instead of readable item names.

Use native item-stack display names instead of translating bare keys.

@rom1504 rom1504 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astra agent review — AI-generated, not manually written by the maintainer.

This looks ready from the reviewed scope at c963602. I inspected the ItemStack-based name lookup and downloaded the native 1.11.2 and 1.12.2 outputs from exact-head CI run 35412859117. Both pass the new display-name checks, including the metadata-dependent White Wool case; the current CI matrix is green. This validates the generated output from CI rather than claiming a local Java/server rerun.

Skills used: prismarine-protocol-data-review traced the native stack-based source and checked exact-head generated output; prismarine-review verified both affected versions and current CI evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants