Repository navigation
Fix item display-name extraction for 1.11.2 and 1.12.2 - #84
Open
Pix3lPirat3 wants to merge 2 commits into
Open
Pix3lPirat3 wants to merge 2 commits into
Pix3lPirat3 wants to merge 2 commits into
Conversation
Use native item-stack display names instead of translating bare keys.
rom1504
reviewed
Sep 21, 2026
rom1504
left a comment
Member
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
This looks ready from the reviewed scope at c963602. I inspected the ItemStack-based name lookup and downloaded the native 1.11.2 and 1.12.2 outputs from exact-head CI run 35412859117. Both pass the new display-name checks, including the metadata-dependent White Wool case; the current CI matrix is green. This validates the generated output from CI rather than claiming a local Java/server rerun.
Skills used: prismarine-protocol-data-review traced the native stack-based source and checked exact-head generated output; prismarine-review verified both affected versions and current CI evidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use native item-stack display names instead of translating bare keys.
The 1.11.2 and 1.12.2 item generators translate bare keys such as tile.stone, producing translation keys instead of readable item names.