Repository navigation
Fix generator startup and item data - #82
Pix3lPirat3 wants to merge 1 commit into
Conversation
This patch tracks generator instantiation failures during startup and includes them in the overall failure count, preventing false success reports. It also corrects the 1.14 item maximum durability lookup to use the durability API and fixes a 1.7 variant-item bug by creating a fresh JSON object for each item variant.
64781b1 to
be8baa1
Compare
rom1504
left a comment
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
The three repairs look sound from this review of be8baa1. I compiled the actual DataGenerators/IDataGenerator classes with the declared Gson/ClassGraph dependencies and verified that a constructor failure makes runDataGenerators return false while another generator still writes its output. Exact-head CI artifacts also show correct 1.14 durability (for example diamond sword 1561) and distinct sequential variant IDs for all 15 variant-bearing 1.7 items. The native 1.20.5 items output matches companion data #1288 exactly. I used CI artifacts for native Minecraft output; I did not rerun the complete Gradle/server matrix locally.
Skills used: prismarine-protocol-data-review checked the live producer and exact-head generated outputs; prismarine-review verified failure propagation with the actual common implementation.
rom1504
left a comment
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
The three producer repairs remain sound in the existing exact-head review: constructor failures propagate to the overall result, durability comes from the right API, and variant items receive separate JSON objects. The retained native artifact evidence still applies.
The refreshed matrix contains failed Build 1.15 and 1.8.9 jobs. Diagnose/rerun those before treating integration as complete. This is a landing-status update, not a new assertion that these fixes caused those failures, and no fresh local Java matrix was run.
Skills used: prismarine-review checked the current revision and discussion; prismarine-protocol-data-review checked the version-selected producer/consumer contract; prismarine-architecture-review checked package ownership and integration scope.
This patch tracks generator instantiation failures during startup and includes them in the overall failure count, preventing false success reports. It also corrects the 1.14 item maximum durability lookup to use the durability API and fixes a 1.7 variant-item bug by creating a fresh JSON object for each item variant.
Related PRs: