[ENG-3771] projects-cli-1: default project UX#732
Open
mrmoxon wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4be637096c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prime lab setupcreate, select, or bind an active Lab project unless--no-projectis passedprime eval push --eval-idavoids implicit reassignmentReview notes
This PR intentionally contains only the default UX layer on top of #731. The explicit projects CLI, API clients, assignment commands, and explicit
--projectplumbing live in #731.Validation
uv run pytest packages/prime/tests/test_rl_config.py packages/prime/tests/test_lab_setup.py packages/prime/tests/test_eval_push.py packages/prime/tests/test_hosted_eval.py packages/prime/tests/test_projects_cli.py packages/prime/tests/test_rl_api.py packages/prime/tests/test_deployments.py packages/prime-evals/tests/test_evals.py -quv run ruff check packages/prime/src/prime_cli/commands/rl.py packages/prime/src/prime_cli/lab_setup.py packages/prime/src/prime_cli/commands/evals.py packages/prime/src/prime_cli/utils/eval_push.py packages/prime/src/prime_cli/verifiers_bridge.py packages/prime/tests/test_lab_setup.py packages/prime/tests/test_eval_push.py packages/prime/tests/test_hosted_eval.pyNote
Medium Risk
Behavior change: new runs/evals may attach to a workspace project without explicit
--project; eval push with--eval-idis guarded, but mis-scoped active projects could group artifacts unexpectedly.Overview
Lab workspaces now default to an active project when you run
prime lab setup(if logged in): it creates or reuses a project from the folder name, or you can bind with--project, name with--project-name, or skip with--no-project.prime project clearrecords a cleared state in workspace context instead of deleting the file, so setup won’t silently re-attach a project until you opt back in.Train, eval run, and eval push resolve
--project/--no-projectagainst the active workspace project by default (resolve_project_idwithuse_active_project). Hosted training always uses the active project; local eval run only when uploads aren’t skipped; eval push uses it for new pushes but not when--eval-idis set (avoids implicit reassignment on updates). Help text and READMEs document the new flow and--no-projecton train/eval push.Reviewed by Cursor Bugbot for commit 450f0ed. Bugbot is set up for automated code reviews on this repo. Configure here.