Improve performance of update of order_cart_rule table data

[Quetzacoalt91]

Questions	Answers
Description?	Fix a bottleneck on a SQL request that contains 2 sub queries to the same table for each row.
Type?	improvement
BC breaks?	Nope
Deprecations?	Nope
Fixed ticket?	Fixes #1561
Sponsor company	@PrestaShopCorp
How to test?	Table contents of order_detail after an update to 1.7.7.0+ is the same before and after the PR.

Technical details

EXPLAIN - Original query

id select_type table type key rows Extra
1 UPDATE od index PRIMARY 100082 NULL
2 DEPENDENT SUBQUERY osd ref idx_id_order_detail 2 NULL
3 DEPENDENT SUBQUERY osd ref idx_id_order_detail 2 NULL

EXPLAIN - Optimized query

id select_type table type key rows Extra
1 UPDATE od ALL NULL 100082 NULL
1 PRIMARY ref <auto_key0> 10 NULL
2 DERIVED test_order_slip_det index idx_id_order… 9689 NULL

Timing

Query	Duration
Original (correlated subquery)	2.258s
Optimized (LEFT JOIN)	0.429s
Speedup	5.3×

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud