Improving Log performance Update 9.1.0.sql#1466
Conversation
|
Sorry i say a mistake you need to rebase : PrestaShop/PrestaShop#39550 (review) |
Prestaworks
force-pushed
the
for-PR-39550
branch
from
6c7545b to
f95b39f
Compare
|
I updated the title |
| ) NOT NULL; | ||
|
|
||
| ALTER TABLE `PREFIX_log` ADD COLUMN `hash` VARBINARY(8000) DEFAULT NULL AFTER `id_employee`, | ||
| ALTER TABLE `PREFIX_log` ADD KEY `hash` (`hash`(3072)); No newline at end of file |
There was a problem hiding this comment.
- What's the use of
(3072)? - Please add an empty line at the end of the file.
There was a problem hiding this comment.
it came from mariadb limiting the length of the key, I changed the column to CHAR 32 instead since it's a md5 hash it should be enough.
it's moved here PrestaShop/PrestaShop#39566 the other one closed when i tried to remove the merge commits |
Update 9.1.0.sql Update upgrade/sql/9.1.0.sql Co-Authored-By: Thomas N <Quetzacoalt91@users.noreply.github.com>
Prestaworks
force-pushed
the
for-PR-39550
branch
from
555f613 to
1849d03
Compare
|
Quetzacoalt91
added
Blocked
|
Blocked until PrestaShop/PrestaShop#39566 is merged |
|
The PR PrestaShop/PrestaShop#39566 It has not been merged for 9.1.0, I think it would be interesting to run the migration script for 9.2.0 if it were to be merged for that version. |
5 participants
Uh oh!
There was an error while loading. Please reload this page.