chore(personhog): fix stale mock path in router AGENTS.md - #91369
Draft
posthog[bot] wants to merge 1 commit into
Draft
chore(personhog): fix stale mock path in router AGENTS.md#91369posthog[bot] wants to merge 1 commit into
posthog[bot] wants to merge 1 commit into
Conversation
The router AGENTS.md pointed at `src/service/tests/mocks.rs`, a path removed when the typed proxy went away. The crate now has no `src/service/` directory and no mock traits. Replace the line with an accurate note about the shared integration-test helpers in `tests/common/mod.rs`, which start real in-process gRPC test servers. Generated-By: PostHog Desktop Task-Id: 935255bb-2a39-40b6-9dae-9a10780492be
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
Author
🦔 PostHog Review reviewed this pull requestNothing worth raising this time, so here's a calming picture instead:
|
posthog
Bot
added
the
skip-agent-review
Contributor
🤖 CI report✅ Trunk lane — non-backend laneThis PR is assigned to the non-backend lane. It does not run backend Python tests and may merge in parallel with PRs in other lanes. |
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
Single-line documentation fix correcting a stale file path reference in a markdown file; no runtime code, no risky territory, content matches description.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 0L, 0F substantive, 3L/1F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T0 auto-approve: T0-deterministic (3L, 1F, single-area, chore) |
| stamphog 2.0.0b4 | .stamphog/policy.yml @ 61861e5 · reviewed head 61861e5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rust/personhog-router/AGENTS.mdfor test conventions was sent tosrc/service/tests/mocks.rs, a path removed when the typed proxy was deleted.src/service/directory and no mock traits (zeromockallreferences), so the line pointed the file's only audience at a directory it could try to recreate.Changes
tests/common/mod.rsand start real in-process gRPC test servers (TestReplicaService,TestLeaderService), not mock traits.CLAUDE.mdis a symlink toAGENTS.md, so the fix reaches both.How did you test this code?
src/service/is absent,grep -rn mockall src tests Cargo.tomlreturns nothing, andtests/common/mod.rsholds the two in-process gRPC test services now named in the file.Automatic notifications
Docs update
None.
🤖 Agent context
Autonomy: Fully autonomous
Authored by the PostHog self-driving agent from an inbox report. The change is a single-line doc fix in
rust/personhog-router/AGENTS.md; no runtime code is touched. The replacement wording was checked againsttests/common/mod.rsso it describes the real helpers rather than repeating the deleted mock-traits claim on a new path.Created with PostHog Desktop from this inbox report, addressing #91368.