Skip to content

fix(gitlab): guide users when the project path has a stray slash #91354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trunk-io merged 1 commit into from
Sep 1, 2026
+9 −4
Merged

fix(gitlab): guide users when the project path has a stray slash #91354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions products/warehouse_sources/backend/temporal/data_imports/sources/gitlab/gitlab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,13 @@ def validate_credentials(
if not project or not project.strip():
return False, "Missing project id or path"

# GitLab addresses a project by its numeric id or a group/project path. A pasted URL or a bare
# group name otherwise URL-encodes into a nonsense path, 404s, and gets reported as "not found
# or not accessible with this token" — which points the user at the token rather than the format.
# GitLab addresses a project by its numeric id or a group/project path. A pasted URL, a bare
# group name, or a stray leading, trailing, or doubled slash otherwise URL-encodes into a
# nonsense path, 404s, and gets reported as "not found or not accessible with this token", which
# points the user at the token rather than the format.
project_ref = project.strip()
if "://" in project_ref or ("/" not in project_ref and not project_ref.isdigit()):
segments = project_ref.split("/")
if not project_ref.isdigit() and ("://" in project_ref or len(segments) < 2 or not all(segments)):
return (
False,
"Enter the project as group/project (for example, mygroup/myproject) or its numeric project ID, not a full URL.",
Expand Down
3 changes: 3 additions & 0 deletions products/warehouse_sources/backend/temporal/data_imports/sources/gitlab/tests/test_gitlab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,9 @@ def test_missing_inputs_short_circuit(self, host, token, project, expected_msg):
"https://gitlab.com/mygroup/", # pasted URL
"mygroup", # bare group, no project and not a numeric id
"some-dashboard", # bare name
"/myproject", # leading slash: encodes to an empty group segment
"mygroup/", # trailing slash: encodes to an empty project segment
"mygroup//myproject", # doubled slash: encodes to an empty middle segment
],
)
def test_malformed_project_gets_format_guidance(self, project):
Expand Down
Loading