Repository navigation
tools: drop-orphan-inline-tables-default reads its run budget from MILLPOND_INLINE_RUN_BUDGET_S, default 300 s - #150
Merged
Merged
Conversation
…LLPOND_INLINE_RUN_BUDGET_S, default 300 s The chain wrapper passed 1800 s, derived from the cron's 18000 s activeDeadlineSeconds divided by six recipes. The bound that matters is the cron cadence: three prod-us tenants run the whole chain every 15 minutes under concurrencyPolicy Forbid, so a step that outlives a tick skips the next tick for every other step, compaction included. 300 s keeps the chain inside one tick. The wrapper reads the budget from the environment so a tenant can be raised from its CronJob spec without touching the chain args, where a parameterized recipe would eat the next word. The explicit recipe's default follows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Review of charts #16725 (the chain change) found that three prod-us tenants run the maintenance chain every 15 minutes under
concurrencyPolicy: Forbid. The wrapper's 1,800 s budget, derived from the 18,000 sactiveDeadlineSecondsdivided by six recipes, would hold the chain past a tick and skip the next one for every other step, compaction included.What
drop-orphan-inline-tables-defaultpasses--run-budget-sfromMILLPOND_INLINE_RUN_BUDGET_S, default300. The explicit recipe's default follows;""still means unbounded,infis the explicit escape hatch.justchain eats the next word.Tests
just --justfile tools/justfile --dry-run drop-orphan-inline-tables-defaultrenders--run-budget-s '300', and--run-budget-s '900'withMILLPOND_INLINE_RUN_BUDGET_S=900(both asserted).ruff checkandruff format --checkclean.Deploy
Release, then retag
:prod(Promote to prod workflow) before charts #16725 merges; the chain references this wrapper first.