fix: raise health poll-age threshold from 300s to 480s - #138
Merged
Conversation
benben
approved these changes
Sep 9, 2026
benben
left a comment
Member
There was a problem hiding this comment.
Automated review generated on behalf of @benben.
Approve. Raises the default liveness/readiness poll-age threshold from 300s to 480s and updates two comments. The change is coherent with the 60s consume cap and the existing probe/Kafka configuration; the only gaps are that the pinning test was deleted in the second commit and the docs still describe 300s.
- minor
tests/unit/test_server.py:8Second commit deleted the only test asserting the new 480s default. Reverting max_poll_age_s to 300 now passes the full suite unchanged. - nit
AGENT.md:466AGENT.md still documents 300s / 5-minute liveness threshold. Lines 383, 466 and 467 reference max_poll_age_s=300. - nit
tests/unit/test_main.py:1000TestConsumeTimeout docstring still says liveness fires at 300s. Docstring not updated alongside the main.py comments.
Model: fable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronous DuckLake writes stop Kafka polling, so a write still making progress after five minutes currently causes
/healthzto fail and can trigger a restart before the batch completes. Raise the default poll-age threshold from 300 to 480 seconds to give slow writes more time to finish and reduce avoidable batch replay after restarts./readyzuses the same health state and also moves to 480 seconds. Kafka's configuredmax.poll.interval.msremains 600,000. The application threshold is not the total time until a pod is killed: Kubernetes probe failures and termination grace still apply. This mitigation delays detection of a genuinely stuck consumer by three minutes and does not resolve DuckLake commit contention.Validation: the existing suite passed (804 tests, 1 expected failure; integration/e2e tests excluded), with five tests rerun outside the sandbox for network/local socket access. Ruff formatting and lint checks passed.