Skip to content

fix(admin): explain Trino recovery blockers - #1239

Merged
benben merged 1 commit into
mainfrom
fix/trino-recovery-eligibility
Sep 25, 2026
Merged

benben merged 1 commit into
mainfrom
fix/trino-recovery-eligibility

Conversation

@benben

@benben benben commented Sep 25, 2026

Copy link
Copy Markdown
Member

Summary

Keep the Trino recovery action visible when an instance is not eligible, and explain the exact blockers instead of hiding the confirmation form.

  • Show actual stored serving and minimum counts, non-draining phase, frozen pool, and missing or invalid admitted identity fields.
  • Keep the new-request action disabled for pending, recorded, retired, or unavailable-preview states, alongside the relevant status.
  • Preserve existing authorization, exact-identity checks, capacity floor, immutable requests, and explicit confirmation requirements. No API, operator, database, or deployment changes.
  • Document that draining alone does not imply recovery eligibility; insufficient serving capacity must be restored first.

Validation

  • Three regression tests reproduced the missing eligibility feedback before implementation.
  • just ui-test: 258 tests pass, including confirmation reset after capacity recovers; typecheck and production build pass.
  • git diff --check: clean.
  • just lint was run and still reports three unrelated baseline issues: cached rawConn.Close errcheck and two reflect.Ptr warnings in installed node_modules/flatted Go source. This PR changes no Go files.

This UI change does not bypass lifecycle checks or resolve a pool capacity deficit. No live recovery is part of this PR.

@benben
benben requested a review from a team September 25, 2026 15:47
@github-actions

Copy link
Copy Markdown

Test Impact Plan

Deterministic summary of how this PR changes tests, CI runners, and coverage-risk signals.

Summary

Area Added Changed Deleted
Test files 0 0 0
E2E/journey files 0 0 0
Workflow files 0 0 0

Signals

  • Test cases: +0 / -0
  • Assertions: +0 / -0
  • Skips or known failures added: 0
  • Workflow continue-on-error added: 0
  • Workflow path filters added: 0
  • Test commands removed from justfile: 0
  • E2E/journey retry lines added: 0

Coverage risk: neutral or increased

No coverage-reduction warnings detected.

@benben
benben merged commit 1b4b288 into main Sep 25, 2026
20 checks passed
@benben
benben deleted the fix/trino-recovery-eligibility branch September 25, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants