fix: match realtimeLLMEventParser filename case to its imports#1725
Open
AnayGarodia wants to merge 1 commit into
Open
fix: match realtimeLLMEventParser filename case to its imports#1725AnayGarodia wants to merge 1 commit into
AnayGarodia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1673
The file is named
realtimeLlmEventParser.ts(lowercasellm) but three handlers import it as../services/realtimeLLMEventParser(uppercaseLLM), matching the exportedRealTimeLLMEventParserclass. Case-insensitive filesystems (macOS, Windows) resolve this fine, but on case-sensitive filesystems (Linux, the Alpine-based Docker image) rollup cannot resolve the import and the build fails.This renames the file to
realtimeLLMEventParser.tsso it matches the import paths and the class name. Together with #1674 it restores the clean Docker build on the2.0.0branch.