fix: move akto plugin under src/plugins so its imports resolve#1724
Open
AnayGarodia wants to merge 1 commit into
Open
fix: move akto plugin under src/plugins so its imports resolve#1724AnayGarodia wants to merge 1 commit into
AnayGarodia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1674
On the
2.0.0branch the akto plugin lives at the repo-rootplugins/akto/, butsrc/plugins/index.tsimports it as./akto/scanand its own sources import../typesand../utils. Those relative imports only resolve undersrc/plugins/(which is wheretypes.tsandutils.tslive), so on a clean checkout rollup cannot resolve the akto module anddocker buildfails.This moves
plugins/akto/tosrc/plugins/akto/(a plaingit mv, no code changes) sosrc/plugins/index.ts's./akto/scanimport and akto's../types/../utilsimports all resolve, matching every other plugin undersrc/plugins/. The existingscan.test.tsmoves with it and now sits alongside the code it tests.