fix(guardrails/azure): guard undefined systemMessages in shieldPrompt#1715
Open
ankit25bcs10610 wants to merge 1 commit into
Open
fix(guardrails/azure): guard undefined systemMessages in shieldPrompt#1715ankit25bcs10610 wants to merge 1 commit into
ankit25bcs10610 wants to merge 1 commit into
Conversation
`systemMessages` is `context.request?.json?.messages?.filter(...)`, so it is `undefined` when the request has no `messages` array (e.g. a completion-style payload). The earlier branch guards this with `Array.isArray(systemMessages)`, but the `documents` spread used a bare `systemMessages.length > 0`, throwing `TypeError: Cannot read properties of undefined (reading 'length')`. Apply the same `Array.isArray` guard here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the Azure
shieldPromptguardrail:systemMessagesisundefinedwhenever the request has nomessagesarray (e.g. a completion-style payload). Thedocumentsspread uses a baresystemMessages.length, throwingTypeError: Cannot read properties of undefined (reading 'length')— and this line is outside the surroundingtry, so the handler rejects instead of returning a clean verdict.Fix
Apply the same
Array.isArray(systemMessages)guard already used a few lines above.npm run format:checkpasses.