fix(reka-ai): guard first-message access in chat transform#1712
Open
ankit25bcs10610 wants to merge 1 commit into
Open
fix(reka-ai): guard first-message access in chat transform#1712ankit25bcs10610 wants to merge 1 commit into
ankit25bcs10610 wants to merge 1 commit into
Conversation
The conversation_history transform dereferenced `messages[0]` before any element was pushed to the local array: - `if (media_url && messages[0].media_url)` throws when the first message is an image (messages is still empty at that point). - `if (messages[0].type !== 'human')` throws when the message list is empty (or fully filtered). Use optional chaining so an image-first or empty message list no longer crashes the transform. Add regression tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
conversation_historytransform inRekaAIChatCompleteConfigdereferencesmessages[0](a local accumulator array) before anything is pushed to it:TypeError: Cannot read properties of undefinedwhen the first message is an image (media_urltruthy,messagesstill empty).Fix
Optional-chain both accesses (
messages[0]?.media_url,messages[0]?.type), so an image-first or empty message list is handled gracefully.Tests
Added
src/providers/reka-ai/chatComplete.test.tscovering both cases. Verified each fails before the fix (throws) and passes after.npm run format:checkpasses.