fix(streaming): handle boundary-not-found in multipart stream transformers#1709
Open
ankit25bcs10610 wants to merge 1 commit into
Open
fix(streaming): handle boundary-not-found in multipart stream transformers#1709ankit25bcs10610 wants to merge 1 commit into
ankit25bcs10610 wants to merge 1 commit into
Conversation
`buffer.indexOf(boundary)` returns `-1` when the boundary is not in the current buffer, but `-1` is not nullish, so `boundaryIndex ?? buffer.length` never falls back — `safeLength` becomes `-1`. When a file chunk arrives before its closing boundary (the normal case for large uploads spanning multiple reads), `buffer.slice(0, -1)` drops the last byte from the emitted content and the non-file branch `buffer.slice(-1)` discards almost the entire buffer, corrupting chunked uploads in getFormdataToFormdataStreamTransformer and formDataToOctetStreamTransformer. Fall back to buffer.length only when the boundary is absent (`boundaryIndex === -1`). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
getFormdataToFormdataStreamTransformerandformDataToOctetStreamTransformer:String.prototype.indexOfreturns-1when the boundary isn't found.-1is not nullish, so?? buffer.lengthnever triggers andsafeLengthbecomes-1.When a file chunk arrives before its closing boundary — the normal case for large uploads streamed across multiple reads — this means:
buffer.slice(0, -1)emits the content minus its last byte, andbuffer = buffer.slice(-1), discarding almost the entire buffer.The result is corrupted chunked file uploads.
Fix
Only fall back to
buffer.lengthwhen the boundary is genuinely absent:Applied at both sites.
npm run format:checkpasses.