fix(google): avoid stream crash when candidate has no content parts#1705
Open
devteamaegis wants to merge 1 commit into
Open
fix(google): avoid stream crash when candidate has no content parts#1705devteamaegis wants to merge 1 commit into
devteamaegis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken
GoogleChatCompleteStreamChunkTransform(in bothgoogleandgoogle-vertex-ai) throwsTypeError: Cannot read properties of undefined (reading '0')when Gemini sends a streamed candidate that has acontentobject but nopartsarray. This happens on terminating chunks withfinishReason: SAFETY/RECITATION/MALFORMED_FUNCTION_CALL, where the candidate looks like{ content: { role: "model" }, finishReason: "SAFETY" }. The exception crashes the entire SSE stream.Why it happens
The branch guards use
generation.content?.parts[0]?....— the optional chaining protectscontentbut notparts, socontent.parts === undefinedthrows. The non-streaming transform already handles this withcontent?.parts ?? []; the streaming path diverged.Fix
Add optional chaining to the array access:
content?.parts?.[0]?....in the three branch guards of each streaming transform. On a parts-less candidate the transform now emits a valid empty-delta chunk carrying thefinish_reasoninstead of crashing.Test
Added
src/providers/google/chatComplete.test.tsasserting the transform does not throw and returnsfinish_reason: "SAFETY"for a parts-less candidate. Fails before the fix (TypeError), passes after.