This repository was archived by the owner on Jul 6, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 144
Add 10 year impacts to app #2502
Merged
Merged
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
f0b337d
feat: Add validaiton objects for society-wide impacts and parse Seque…
anth-volk 202dad9
chore: Refactor SocietyWideImpact into new file
anth-volk 9f0271b
feat: Validate impacts
anth-volk c341c34
feat: Add aggregation for budgetary impacts
anth-volk eee2f9e
feat: Aggregate budgetary impacts
anth-volk 75af92b
fix: Remove testing objects
anth-volk 3e5f753
feat: Add decile data aggregation
anth-volk 9d4fa12
feat: Add inequality aggregation
anth-volk 18e1a8f
feat: Add standard poverty data aggregation
anth-volk 052ef0c
feat: Aggregate poverty by gender
anth-volk 78dcc41
feat: Aggregate poverty by race
anth-volk 2df0018
feat: Aggregate LSRs
anth-volk 1b56a1e
feat: Implement intra-decile impacts
anth-volk 9f64a45
feat: Add constituency impacts
anth-volk 6daa5f1
fix: Correct how winners and losers works
anth-volk 199f5b8
feat: Add detailed budget view
anth-volk 258cfb0
feat: Add intra-wealth deciles
anth-volk 906db6c
feat: Add wealth deciles
anth-volk 7116cc9
fix: Modify constituency setup
anth-volk 230b80f
feat: Create separate schemas for US and UK
anth-volk af156f1
fix: Remove aggregated impacts to split up PR
anth-volk 71e7d39
feat: Add refactored society-wide aggregation functions
anth-volk 6129369
feat: Add refactored aggregation for UK
anth-volk ef2d9df
test: Tests for aggregateSocietyWideImpactsUS
anth-volk 0f6f72e
test: Add tests for aggregateSocietyWideImpactsUK
anth-volk 4fd8847
chore: Test validateImpacts
anth-volk 7196054
chore: Test for aggregateInequalityModule
anth-volk 7f0dea7
test: Add tests for LSR module
anth-volk e07d08d
feat: Create schema for aggregated society-wide impacts
anth-volk 07eb1b1
fix: Remove unneeded modules
anth-volk 987c2c8
test: Correct aggregate test
anth-volk 074f675
test: Remove unneeded LSR test
anth-volk 243e30e
test: Fix tests for aggregate.js
anth-volk bfbb6f4
feat: Add simYears URL query param
anth-volk 0444719
fix: Make fixes to underlying functions, partially implement logic
anth-volk e8e609c
feat: Create aggregated output and display
anth-volk 5a2774b
fix: Remove unnecessary log statements
anth-volk fa3dc7b
feat: Disable options in multi-year runs
anth-volk 1adfdba
chore: Remove needless logs
anth-volk 40e6e53
feat: Correct display of data values on multi-year outputs
anth-volk 9f6ada2
feat: Partially implemented multi-year selector
anth-volk 8abc0c5
feat: Add component to enable multi-year outputs
anth-volk 704b5d4
fix: Fixes to logic
anth-volk 5200392
fix: Alter how disabling of policy output tree items is done
anth-volk e34e754
fix: Use tree.js to determine what pages to display, then create temp…
anth-volk 78494a8
feat: Beginnings of multi-year budgetary impact component
anth-volk dce518c
test: Add test for MultiYearSelector
anth-volk 753dfa2
test: Add test for MultiYearBudgetaryImpact.jsx
anth-volk be7a799
feat: Add correct title to 10-year impact component
anth-volk 3ffc49b
fix: Correctly show budgetary impact page when multi-year after click…
anth-volk b38ecc7
fix: Toggle between correct views between multi-year and standard out…
anth-volk 0b9bcba
fix: Correct transition when toggling menu
anth-volk 34ba69a
test: Fix makeSequentialSimulationRequests tests
anth-volk 90180a1
fix: Fix tests for MultiYearBudgetaryImpact
anth-volk 81698f5
fix: Remove deprecated test
anth-volk d7464d5
fix: Fix all remaining tests
anth-volk 2d1da39
fix: Show currency marker correctly
anth-volk 81021b5
fix: Fix UK formatting
anth-volk d026210
fix: Visual styling changes
anth-volk 85863ba
fix: Merge conflict fixes
anth-volk 5a8342e
fix: Merge conflict fixes
anth-volk 4617dbf
fix: Consume new format
anth-volk 57e8225
fix: Fix tests
anth-volk a9bc073
fix: Fix switching issue
anth-volk 1b554fd
fix: Remove enhanced_us maintenance code
anth-volk 9535e18
fix: Add variable rounding by country package
anth-volk 042c124
fix: Properly assign output categories
anth-volk deb97d1
fix: Add capability to calculate formulas
anth-volk a6ca8c5
chore: Remove console logs
anth-volk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still inconsistent I believe: federal tax revenue impact is
tax_revenue_impact- state_tax_revenue_impact.I would look at this part of the codebase to see exactly which variables map to which concepts and just mirror that. Apologies for missing this in earlier reviews if this was part of one of the chained PRs: I think if in future we could just combine PR dependent on each other in the same repo that would make it easier to review.