fix(perps): record native liquidation bad debt#142
Draft
rndrntwrk wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the native perps liquidation accounting gap identified during the contracts audit.
Before this change,
AgentPerpEngineNative.liquidate()used realized PnL only to decide whether a position was liquidatable. The liquidation path then paid the reward from raw margin and credited any remaining raw margin toinsuranceFund, even when the position's realized loss exceeded margin. That made insolvent liquidations look solvent and leftbadDebtat zero.This PR makes native liquidation apply the same accounting invariant as the ERC20 perps engine:
market.badDebtTests
forge test --match-path test/perps/AgentPerpEngineNative.t.solforge test --match-path test/perps/AgentPerpEngine.t.solforge test --match-path test/perps/AgentPerpEngineFuzz.t.solforge test --match-path test/perps/PmPerpsAdversarial.t.solforge test --match-path 'test/perps/*.t.sol'forge buildgit diff --checkforge fmt --check contracts/perps/AgentPerpEngineNative.sol test/perps/AgentPerpEngineNative.t.solstill reports pre-existing formatting drift in untouched portions ofAgentPerpEngineNative.sol, so the patch keeps formatting minimal instead of reformatting the broader file.Audit Notes
This PR is intentionally narrow. It does not include the separate
security/native-perps-equity-healthwithdrawal-health fix, and it does not change the ERC20 perps engine.