fix(clob): sweep only unreserved native excess#140
Draft
rndrntwrk wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the GoldClob custody issue found during the contract audit.
Before this patch,
sweepETH()transferred the entire native balance to treasury. GoldClob uses that same balance for resting-order escrow, matched position collateral, cancellation refunds, and unresolved winner payouts, so the sweep path could drain user funds even though the storage liabilities remained active.This patch adds native reserve accounting and limits
sweepETH()to unreserved excess only.Security Impact
reservedNative.reservedNative.sweepETH()can only transferaddress(this).balance - reservedNative.Verification
testSweep*tests failed against the vulnerable whole-balance sweep.env FOUNDRY_LIBS='["../../node_modules","lib"]' forge test --match-path test/GoldClobSettlement.t.sol --match-test 'testSweep'-> 3 passed, 0 failedenv FOUNDRY_LIBS='["../../node_modules","lib"]' forge test --match-path test/GoldClobSettlement.t.sol-> 8 passed, 0 failedenv FOUNDRY_LIBS='["../../node_modules","lib"]' forge test --match-path test/GoldClobStress.t.sol-> 10 passed, 0 failedenv FOUNDRY_LIBS='["../../node_modules","lib"]' forge test --match-path test/fuzz/GoldClobFuzz.t.sol-> 4 passed, 0 failedgit diff --check-> passStaging Policy
This PR targets
mainand is intentionally draft while review is pending. The same patch will be replayed intoenoomian/stagingfor staging deployment and testing, but this effective PR remains open as the merge vehicle.