chore(ui): drop unused canonicalPlayback destructure from solana + bsc App#137
Draft
rndrntwrk wants to merge 1 commit into
Draft
chore(ui): drop unused canonicalPlayback destructure from solana + bsc App#137rndrntwrk wants to merge 1 commit into
rndrntwrk wants to merge 1 commit into
Conversation
…c App `packages/hyperbet-solana/app/src/App.tsx` and `packages/hyperbet-bsc/app/src/App.tsx` both destructure `playback: canonicalPlayback` from `useCanonicalStreamSession()` but never read the binding. ESLint's `@typescript-eslint/no-unused-vars` rule (`--max-warnings=0`) hard-fails the `Pre-PR Ready Check` gate on every new PR that triggers a re-lint of these packages, including the in-flight `security/lvr-amm-bootstrap-authority` (#135) and `security/lvr-amm-disable-dynamic-liquidity` (#136) audit fixes. Removing the unused destructure unblocks those PRs without expanding their scope. Hook return shape is unchanged; if a future caller needs the playback field it can be re-added with a real consumer in the same diff. EVM `App.tsx` was already clean — no change there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
playback: canonicalPlaybackdestructure fromuseCanonicalStreamSession()in two App shells:packages/hyperbet-solana/app/src/App.tsx:765packages/hyperbet-bsc/app/src/App.tsx:736Both bindings are declared but never read. ESLint's
@typescript-eslint/no-unused-varsrule (configured with--max-warnings=0) hard-fails the Pre-PR Ready Check gate as a result.Why
This lint debt has been on
enoomian/stagingsince before audit kickoff. It is currently blocking the in-flight security PRs:fix(solana): require upgrade authority for lvr amm bootstrapfix(amm): disable unsafe dynamic liquidity marketsBoth PRs are otherwise green; their
Pre-PR Ready Checkstep fails onhyperbet-solana app lint(andhyperbet-bsc app lintfollows next). Neither PR touchesApp.tsx, so the lint failure is inherited from the base branch, not introduced by them.This change is the minimal fix to unblock both audit PRs without expanding their scope.
Changes
playback: canonicalPlayback,line from theuseCanonicalStreamSession()destructure inhyperbet-solana/app/src/App.tsx.hyperbet-bsc/app/src/App.tsx.The hook return shape is unchanged —
useCanonicalStreamSession()still exposes.playbackto any future caller. If a future diff needs the playback field, it can be re-added in the same diff that introduces the consumer.EVM
App.tsxwas already clean (nocanonicalPlaybackdestructure); no change there.Validation
cd packages/hyperbet-solana/app && bun run lint— PASScd packages/hyperbet-bsc/app && bun run lint— PASSRollout
Merging this into
enoomian/stagingfirst will unblock the Pre-PR Ready Check gate for #135 and #136 so they can be reviewed and merged on their own merits.Explicit non-goals
useCanonicalStreamSessionhook itself.