[COPY OF #24434] pp_accept: fix potential out-of-bounds read on oversized accept() addrlen#24447
Open
crystarm wants to merge 1 commit into
Open
[COPY OF #24434] pp_accept: fix potential out-of-bounds read on oversized accept() addrlen#24447crystarm wants to merge 1 commit into
crystarm wants to merge 1 commit into
Conversation
crystarm
changed the title
crystarm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COPY OF #24434
Summary: This PR fixes a potential out-of-bounds read in
pp_accept(pp_sys.c).Problem:
PerlSock_accept_cloexec()(viaaccept()/accept4()) can return anaddrlenlarger than the supplied buffer size when the peer address is truncated. The previous code used the returnedlendirectly inPUSHp(namebuf, len).Fix: Clamp
lentosizeof(namebuf)before callingPUSHp.Impact: No behavior change for valid lengths. Prevents reading past
namebufwhenaddrlenis oversized.Context: Change was motivated by static analysis finding. BUFFER_OVERFLOW.PROC pp_sys.c:[2631:10].log
This set of changes does not require a perldelta entry.