Improve makerel EBCDIC handling#24444
Open
khwilliamson wants to merge 7 commits into
Open
Conversation
There is nothing besides the -c for that option
This is in preparation for a future commit which will need the extra flexibility
We only want to translate Latin1/UTF-8/UTF-16 files to EBCDIC in that mode. Other encodings should be left alone. This commit looks for =encoding lines indicating such alien encoded files. Some of these previously showed up as binary files. But look for =encoding first to give the proper message.
Some files aren't translatable to EBCDIC, like binary files (.gz for example) or files that are known to be in a non-Latin1 encoding (like Cyrillic). This adds lists of those, and suppresses mention of them. Then should a file newly start to have a message, it will be more noticeable.
Besides 1047, Perl also has tables to handle CP 037, though we have no known active systems using that. (There were protests last time we considered removing them.) I believe the core has improved enough that we could handle any code page which is isomorphic to Latin1 just by adding a table. (If not isomorphic to Latin1, that would be a big big deal to add and not worth doing.) Anyway, this commit adds the ability to specify CP 037 as the output of this command, and it would be trivial to add any other CP that we were to add tables for.
khwilliamson
added
the
defer-next-dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to generate a tarball for CP 037, besides previously just CP1047, suppresses messages about known outlier files, and adds special handling for files known to be encoded in a format that shouldn't be translated to EBCDIC, such as Japanese