Time::HiRes: make nanosleep.t more robust against busy systems#24405
Open
tonycoz wants to merge 1 commit into
Open
Time::HiRes: make nanosleep.t more robust against busy systems#24405tonycoz wants to merge 1 commit into
tonycoz wants to merge 1 commit into
Conversation
leonerd
reviewed
May 4, 2026
Contributor
leonerd
left a comment
leonerd
left a comment
There was a problem hiding this comment.
One unused variable, but otherwise looks good.
| my $d = $f2 - $f; | ||
| my $max_trials = 10; | ||
| my $trials = 0; | ||
| my $ok = 0; |
Contributor
There was a problem hiding this comment.
$ok appears to be unused in the subsequent code
ap
added
the
defer-next-dev
Contributor
|
PSC opinion is that this should bake for a bit, so it’ll have to wait for next cycle. |
This now does up to 10 trials see if a nanosleep takes something like the expected maximum limit of duration. If any trial takes less than that limit the trials finish and falls through to the test checks. If any trial takes less than the minimum expected by the test the test still fails, since I'd expect a busy system to extend the duration, not reduce it. Fixes Perl#24284
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now does up to 10 trials see if a nanosleep takes something like the expected maximum limit of duration.
If any trial takes less than that limit the trials finish and falls through to the test checks.
If any trial takes less than the minimum expected by the test the test still fails, since I'd expect a busy system to extend the duration, not reduce it.
Fixes #24284