Use C99 designated initialisers for PerlIO_funcs#24390
Open
ilmari wants to merge 1 commit into
Open
Conversation
This avoids having to count NULLs for layers that only implement a subset of functions.
Leont
approved these changes
Apr 25, 2026
Contributor
|
I think it is a silly warning with designated initializers, but g++ produces a mess of warnings: Adding C++ default initializers prevents the warnings but that would be a mess of macros for us. I suspect the best choice would be to suppress the warning: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids having to count NULLs for layers that only implement a subset of functions.