-
Notifications
You must be signed in to change notification settings - Fork 36
Redesign Excerpt Suggestions with core-native patterns #4489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9da04c3
Redesign Excerpt Suggestions panel with core-native patterns
dabowman ee009b5
Attribute excerpt accepted/discarded telemetry at save time
dabowman dbd1346
Address PR review feedback
dabowman 4df2514
Simplify the excerpt panel footer
dabowman fa86eda
Anchor the settings popover to the actions row
dabowman 2cc747c
Harden Excerpt Suggestions and raise the WP floor to 6.1
dabowman ae4329c
Pass the AI icon to the Generate button as a component
dabowman 30360d1
Restore the Generate button's icon-and-text padding
dabowman 16b856e
Move Excerpt Suggestions out of the Editor Sidebar feature list
dabowman 1bb2721
Send a default tone and persona instead of the custom sentinel
dabowman ce7e91f
Merge branch 'develop' into improve-ai-features
acicovic 1d32555
Merge branch 'develop' into improve-ai-features
acicovic 8d2dd6f
Sync the excerpt panel's loading state across remounts
acicovic aceef1e
Stop dropping settings changes when the popover closes
acicovic 9e4008e
Stop reporting rewritten excerpts as accepted suggestions
acicovic 64cacd6
Discard excerpt responses that arrive after the post changed
acicovic 3566dd0
Sync debounced setting refs after commit instead of during render
acicovic 7a5da56
Improve keyboard and screen reader access to the excerpt controls
acicovic 0c53b25
Share one custom tone and persona length limit
acicovic daa6d1a
Document each excerpt length constant separately
acicovic 946e234
Reuse the excerpt default persona and tone constants
acicovic 8e8f310
Correct two overstated excerpt panel docblocks
acicovic c7d2339
Add tests for the excerpt panel's generation and save behavior
acicovic 4121ce7
Cover the snackbar Undo path in the excerpt panel tests
acicovic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| <?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-data', 'wp-escape-html', 'wp-i18n', 'wp-url'), 'version' => 'f28647bb0d44468aed15'); | ||
| <?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-data', 'wp-escape-html', 'wp-i18n', 'wp-url'), 'version' => 'bf94b77e4a146061cd92'); |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.