feat: add checkout domain verification status from api-specifications#2416 - #238
Draft
cursor[bot] wants to merge 1 commit into
Draft
feat: add checkout domain verification status from api-specifications#2416#238cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Jed Patterson <jed.patterson@paddle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the public Checkout Domains resource and folds in the pending DX-906 baseline so the status change from api-specifications#2416 is available in the Node SDK.
The public approval-status union includes
action_requiredandverification_in_progress, excludes internalarchived, and documents the corrected meaning ofin_review. This additive surface bumps the package version to3.11.0.Linear issue: DX-1092
Spec-to-SDK mapping
verification_in_progressresponse status and revisein_reviewdocumentationsrc/enums/checkout-domains/checkout-domain-approval-status.ts,src/types/checkout-domains/checkout-domain-response.ts,src/entities/checkout-domains/checkout-domain.tsverification_in_progressin the list status filtersrc/resources/checkout-domains/operations/list-checkout-domains-query-parameters.tssrc/resources/checkout-domains/**,src/entities/checkout-domains/**,src/types/checkout-domains/**,src/enums/checkout-domains/**,src/paddle.ts, and root barrelssrc/__tests__/mocks/resources/checkout-domains.mock.ts,src/__tests__/resources/checkout-domains.test.tsCHANGELOG.md,package.jsonIntentionally excluded
CheckoutDomainStatusUpdateand its PATCH operation remain@internalUseOnly.@partnerOnly.archivedremains excluded because it is internal in the query enum.Validation
pnpm install --frozen-lockfile— passedpnpm build— passedpnpm typecheck:tests— passedpnpm test --runInBand— 35 suites and 281 tests passed, including 4 Checkout Domains testspnpm lint— passedpnpm prettier— passedThis PR was created by an automated spec-sync agent.