fix: task list 500s when combining assignee_id=null with assignee_ids#276
Merged
Conversation
Combining the "unassigned" filter (assignee_id=null) with the "assigned to specific users" filter (assignee_ids=<uuid>) produced a WHERE clause with unbalanced parentheses, causing Postgres to reject the query with a syntax error and the task list endpoint to 500. Fixes #272 Co-authored-by: R0hit-Sriram <222852898+R0hit-Sriram@users.noreply.github.com>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — fixed an unbalanced-parentheses SQL clause generated by applyTaskFilter when AssigneeNull and AssigneeIDs are both set, and added a regression test for the combined filter.
- Balanced the
assignee_id IS NULL OR INclause — adds the missing closing)inservices/api/internal/repository/postgres/task_repository.go. - Added
task_repository_test.go— uses an in-memory SQLite database to exerciseCountTaskswithAssigneeNull: trueand a non-emptyAssigneeIDslist, matching the pattern used by other repository tests in this package.
Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyTaskFilter(services/api/internal/repository/postgres/task_repository.go) that produced an unbalanced-parens WHERE clause whenever both the "unassigned" filter and the "assigned to specific users" filter were combined (assignee_id=null+assignee_ids=<uuid>), causing Postgres to reject the query with a syntax error and the task list endpoint to 500.task_repository_test.go) exercisingCountTaskswithAssigneeNullandAssigneeIDsboth set, which fails with the old code (incomplete input) and passes with the fix.Test plan
go build ./...go test ./internal/repository/postgres/...incomplete inputSQL error) and passes with the fix applied.Fixes #272
🤖 Generated with Claude Code