Skip to content

fix: verify downloaded files before completion #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lhx077 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: verify downloaded files before completion #3040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Plain Craft Launcher 2/Modules/Network/Loaders/LoaderDownload.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ private async Task ProcessFileAsync(PCL.Network.DownloadFile file, CancellationT
{
await FileDownloader.Download(file.Urls, file.LocalPath, file.UseBrowserUserAgent, file.CustomUserAgent,
cancellationToken, enableParallelChunks, file).ConfigureAwait(false);
var checkError = file.Check?.Check(file.LocalPath);
if (checkError is not null)
throw new IOException($"下载文件校验失败：{checkError}");
Comment on lines +140 to +142

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Try alternate mirrors after checksum failures

When the first URL returns a complete but invalid file, this check throws only after FileDownloader.Download(...) has already returned; DownloadCoreAsync stops at the first transport-successful URL (FileDownloader.cs lines 51-57), so the exception is caught by the outer retry loop and the same first URL is retried up to four times instead of falling through to later mirrors. For multi-source downloads where mirror 1 is corrupt or malicious but mirror 2 is valid, this makes the whole download fail despite an available good source; the integrity check needs to participate in the per-URL failure path or otherwise advance to the next URL.

Useful? React with 👍 / 👎.

break;
}
catch (OperationCanceledException)
Expand Down
Loading