Repository navigation
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MaxLardenois
left a comment
MaxLardenois
left a comment
There was a problem hiding this comment.
I think we should not modify dropdown, footer and table as those are draft components coming from Boosted. We will circle back to it when we have a real implementation
I cannot do a Copilot review but I asked an agent if there was other custom props we could remove and here is what it output
-------- LLM output ----
Strongest candidates
_text-input.scss:23: --text-input-border-width-focus is declared but never read. It can be removed outright.
_tags.scss:19: --tag-warning-external-icon only aliases --alert-warning-icon; the two uses can reference the alert variable directly.
_text-input.scss:703: --text-input-message-margin-top is a fixed token used for helper/error margins. Those uses could take the Sass token directly.
_control-item.scss:190: --checkbox-check-icon is a fixed alias to $checkbox-selected-icon. Its two mask uses could use the Sass icon directly, if per-control runtime icon overrides aren’t intended.
Possible, but documented customization hooks
_breadcrumb.scss:6: --breadcrumb-item-gap is assigned once from a fixed token and never changed internally.
In _text-input.scss:25, the fixed-token properties text-input-padding-x/y, text-input-icon-size, text-input-trailing-action-, and text-input-column-gap have no internal overrides. They could use Sass values directly, but they’re inside the documented text-input CSS-variable blocks, so removing them would reduce the documented runtime customization API.
| content: ""; | ||
| background-color: currentcolor; | ||
| mask-image: var(--#{$prefix}breadcrumb-divider); | ||
| mask-image: #{escape-svg($breadcrumb-divider-icon) "/* rtl:"escape-svg($breadcrumb-divider-flipped) "*/"}; |
There was a problem hiding this comment.
We should remove the escape-svg and the RTL stuff as it will be done on its own later on.
We should use directly the value of $breadcrumb-divider as it is a Bootstrap variable.
| height: $ouds-breadcrumb-size-icon; | ||
| margin-left: var(--#{$prefix}breadcrumb-item-gap); | ||
| color: var(--#{$prefix}breadcrumb-divider-color); | ||
| color: $breadcrumb-divider-color; |
There was a problem hiding this comment.
We should use the value of $breadcrumb-divider-color as it is a bootstrap variable
Types of change
Related issues
Closes #3593
Description
Removed custom props being defined only once in favor of using their value.
Checklists
Checklist (for Core Team only)
Progression (for Core Team only)
mainfollowing conventional commitLive previews