Repository navigation
feat(lib): Add Typography as components and h2 heading marker #3776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
9b55676
4b49f62
5b87f62
dd2d86a
76c59b5
c0662a1
8df5798
3772a49
c334f2e
cfc8399
4f25b55
f4510d7
5547628
e664056
5b10cfa
9f1059c
d0b1f0e
eba3249
3bfc0d2
3dff28e
32f4f75
e8f9c7d
35399db
8784c6b
587f2a4
7032616
acef91d
c8e19df
7eee8b7
ccce50c
67d9d1e
7bc5971
2dab1f8
a294fb8
8c6155c
f889784
5da7495
e08f97f
dd2c7d4
094ed0d
bb16f4d
fe8ea3b
f8317b1
0d11af4
3960fe4
e907426
8861b5d
6a744b9
959a46d
ecd7229
ad3bd70
80107da
a29e0b8
fd09ab0
18ce773
3eca2fc
1b630be
3253244
62a2689
d601f33
80f57c9
1f49605
757816b
d7c2c77
15654ed
76a532a
830adfc
35ca0d6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,6 +63,12 @@ $ouds-font-family-monospace-stack: | |
| Menlo, | ||
| monospace !default; | ||
| // scss-docs-end ouds-composite-font-monospace | ||
| // scss-docs-start ouds-composite-typography | ||
| // NB: Set here the marker SVG exported from Figma, including paddings, with no `fill` attributes. Set it to null if there is not marker available for this theme. | ||
| $ouds-heading-large-marker-img: url("data:image/svg+xml,<svg width='30' height='12' viewBox='0 0 30 12' xmlns='http://www.w3.org/2000/svg'><rect y='4' width='30' height='6'/></svg>") !default; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where is this from ? How can we find it back if it changes ? How will it be warned about ?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this SVG is exported from Figma, and is expected to contain paddings, plus it shouldn't have any
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't it counted as an icon that we have in the icon packages ?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no it is not in the icon package, it does not have the same size or viebox, so it is not considred as an icon
louismaximepiton marked this conversation as resolved.
Resolved
louismaximepiton marked this conversation as resolved.
Resolved
|
||
| $ouds-heading-large-marker-width: 30px !default; | ||
| $ouds-heading-large-marker-height: 12px !default; | ||
| // scss-docs-end ouds-composite-typography | ||
| // stylelint-enable value-keyword-case, scss/dollar-variable-colon-space-after | ||
|
|
||
| //// ****** ICONS as data URIs ****** | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,6 +54,12 @@ $ouds-font-family-monospace-stack: | |
| Menlo, | ||
| monospace !default; | ||
| // scss-docs-end ouds-composite-font-monospace | ||
| // scss-docs-start ouds-composite-typography | ||
| // NB: Set here the marker SVG exported from Figma, including paddings, with no `fill` attributes. Set it to null if there is not marker available for this theme. | ||
| $ouds-heading-large-marker-img: null !default; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What do you think about :
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be consistent with the naming of the class, after the opinion of Vincent will be given |
||
| $ouds-heading-large-marker-width: 0 !default; | ||
| $ouds-heading-large-marker-height: 0 !default; | ||
| // scss-docs-end ouds-composite-typography | ||
| // stylelint-enable value-keyword-case, scss/dollar-variable-colon-space-after | ||
|
|
||
| //// ****** ICONS as data URIs ****** | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -260,8 +260,29 @@ dd { | |
|
|
||
| // Blockquote | ||
|
|
||
| .blockquote, // deprecated in OUDS Web v1.6 | ||
| blockquote { | ||
| margin: 0 0 $ouds-space-fixed-medium; // OUDS mod: instead of `0 0 1rem` | ||
|
|
||
| > p { | ||
| @include get-font-size("body-large"); | ||
| } | ||
|
|
||
| > :last-child { | ||
| margin-bottom: 0; | ||
| } | ||
| } | ||
|
|
||
| .blockquote-footer, // deprecated in OUDS Web v1.6 | ||
| blockquote + figcaption { | ||
| margin-top: -$ouds-space-fixed-medium; | ||
| margin-bottom: $ouds-space-fixed-medium; | ||
| @include get-font-size("body-small"); | ||
| color: var(--#{$prefix}color-content-muted); | ||
|
|
||
| &::before { | ||
| content: "\2014\00A0"; // em dash, nbsp | ||
| } | ||
| } | ||
|
|
||
| // OUDS mod: No italic | ||
|
|
@@ -397,7 +418,6 @@ pre { | |
| margin-bottom: $ouds-space-fixed-medium; // 2 // OUDS mod: instead of `1rem` | ||
| overflow: auto; // 3 | ||
| @include get-font-size("code-medium"); // OUDS mod: instead of `font-size: $code-font-size` | ||
| color: $pre-color; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as #3776 (comment) |
||
|
|
||
| // Account for some code outputs that place code tags in pre tags | ||
| code { | ||
|
|
@@ -411,7 +431,6 @@ var, // OUDS mod | |
| code { | ||
| font-size: $code-font-size; | ||
| font-style: normal; // OUDS mod: <var> is italic in all browsers | ||
| color: var(--#{$prefix}color-content-muted); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still not a big fan of removing it, since all documentation generators will generate default color code which is barely visible imo and will encourage people to use every color they can use, for example For instance if we keep it like that, we should also remove :
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To confirm with @vprothais wether we keep the grey color or not? |
||
| word-wrap: break-word; | ||
| } | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.