remove Upgrades header - #613
Open
muald wants to merge 4 commits into
Open
Conversation
muald
force-pushed
the
fix-remove-upgrades-header
branch
3 times, most recently
from
August 19, 2026 08:47
5de3be7 to
caea9df
Compare
Signed-off-by: Markus Urbanczyk <markus.urbanczyk@evosoft.com>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
When `puppet generate types` is run, it scans the `modulepath` in an environment and compiles environment-isolated implementations for each module that contains a `puppet/type/` sub-directory. When run with debug logging enabled, the command prints the name of each module skipped due to the types sub-directory not being visible. This commit updates the debug-level message to add the path to the module directory that was examined. Module discovery is done by walking the `modulepath`, which is a prioritized list of locations that modules can be loaded from. Including the directory path in the debug message gives users a signal that can indicate when a module has been shadowed by another directory with the same name, but higher precedence on the `modulepath`. Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
muald
force-pushed
the
fix-remove-upgrades-header
branch
from
August 19, 2026 09:00
caea9df to
8fbb446
Compare
Author
|
Can one of the reviewers with write access review this pull request, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Remove the Upgrades header. The update process in Fedora 44 was blocked by this header.
#555 (comment)
The header was introduced 7 months ago.
https://github.com/rpm-software-management/dnf5/blob/main/dnf5/commands/check-upgrade/check-upgrade.cpp#L211
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent