Participant import rework - #6182
Conversation
05f9e93 to
46cbeba
Compare
| <os-backend-import-list | ||
| additionalInfo="{{ | ||
| 'Existing accounts can be reused or updated by using: <ul><li>Membership number <i>(recommended)</i><li>Username<li>Email address AND first name AND last name' | ||
| 'Existing accounts can be reused or updated by using:<p>• Membership number <i>(recommended)</i><br>• Username<br>• Email address AND first name AND last name' |
There was a problem hiding this comment.
This change seems unintended.
| styleUrls: [`./head-bar.component.scss`], | ||
| encapsulation: ViewEncapsulation.None, | ||
| changeDetection: ChangeDetectionStrategy.Eager, | ||
| // changeDetection: ChangeDetectionStrategy.Eager, |
There was a problem hiding this comment.
Very likely a bad idea to remove this.
| > | ||
| @let entry = row.data; | ||
| @let type = column.type; | ||
| <div *osScrollingTableCellLabel>{{ getColumnLabel(column.property) }}</div> |
| @if (getHeader(def).type === 'boolean') { | ||
| <mat-checkbox disabled [checked]="item.value" /> | ||
| } | ||
| |
| @Input() | ||
| public csvConfiguration: boolean; | ||
|
|
||
| @Output() | ||
| public selectedEncodingOutput = new EventEmitter<V>(); | ||
|
|
||
| @Output() | ||
| public selectedColSepOutput = new EventEmitter<V>(); | ||
|
|
||
| @Output() | ||
| public selectedTextSeparatorOutput = new EventEmitter<V>(); | ||
|
|
||
| @Output() | ||
| public selectNewFile = new EventEmitter<Event>(); | ||
|
|
||
| @Input() | ||
| public csvReloadButton: boolean; | ||
|
|
||
| @Input() | ||
| public csvReload: ParticipantImportService; | ||
|
|
There was a problem hiding this comment.
I do not want this in here.
| /** | ||
| * Summary adapted to the footer. Displays only "created", "updated", "referenced" and "error" columns. | ||
| */ | ||
| @Input() | ||
| public shortenedSummary: BackendImportSummary[]; | ||
|
|
||
| /** | ||
| * Information to display the correct icons in footer | ||
| */ | ||
| @Input() | ||
| public GetSummaryInformation; | ||
|
|
There was a problem hiding this comment.
This is also not supposed to be in here. This is a generic component. Specific things should be implemented here by inheritance or by utilizing another (maybe more flexible) component.
| /** | ||
| * Summary adapted to the footer. Displays only "created", "updated", "referenced" and "error" columns. | ||
| */ | ||
| @Input() | ||
| public shortenedSummary: BackendImportSummary[]; | ||
|
|
There was a problem hiding this comment.
Not supposed to be in here.
| > | ||
| @if (showHeader && horizontalScroll) { | ||
| <div class="scrolling-table-header"> | ||
| <ng-container [ngTemplateOutlet]="tableHeader"></ng-container> |
There was a problem hiding this comment.
I don't really see why you would use template outlets here.
|
|
||
| public set labelTemplate(template: any) { | ||
| setTimeout(() => (this._labelTemplate = template)); | ||
| this._labelTemplate = template; |
There was a problem hiding this comment.
We do not really know why this was done. When I suggested this change I asked you to further investigate. I can imagine that this could lead to problems in places where tables are statically defined and the labels container is not yet finished initializing. This might explain why you had to remove change detection Eager at some places. Please at the very least check usages in other places still work.
MSoeb
left a comment
MSoeb
left a comment
There was a problem hiding this comment.
Several changes needs to be done. Talked with @Borreg0 about it.
Here a list of next steps:
2026-07-30 - PR6182.txt
If you need an explanation please contact me :)
3 participants
closes #5124