Add BIDS RTD PR-preview origins to CORS (temporary)#319
Merged
Conversation
Allow the BIDS assistant widget to load on the ReadTheDocs PR preview builds for bids-standard/bids-specification#2442 and bids-standard/bids-website#847 so reviewers can try the widget before merge. These two origins are temporary and should be removed once both PRs merge.
Contributor
|
This PR modifies community CORS origins. Worker changes detected. After merging to Manual deployment (if needed): cd workers/osa-worker
wrangler deploy --env dev # for develop branch
wrangler deploy # for main branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ReadTheDocs PR-preview origins for the two BIDS widget PRs to the BIDS community
cors_originsso reviewers can actually try the assistant on the preview builds:The RTD preview hosts resolve to the production OSA worker (the widget's env-detection treats
*.org.readthedocs.buildas neither dev nor demo), so these origins are needed on prod for the preview pages to call the API.Temporary
Both entries are clearly commented as temporary and should be removed once the two upstream PRs merge (the permanent
bids.neuroimaging.ioandbids-specification.readthedocs.ioorigins already cover the live sites).Testing
CommunityConfigparses the updated YAML and both new origins pass thecors_originsvalidator.Deploy note
CORS is built at FastAPI startup from each community config, so this needs a backend restart/redeploy to take effect on the environment serving the preview (production).