Repository navigation
Conversation
…c#848, issue OpenMontageInc#819) Every upstream commit, PR and issue above the previous watermarks was classified in docs/DECISIONS.md and the verification gates passed. tools/tests/test_fork_docs.py pinned the exact previous reviewed_through SHA, which can only fail once the watermark moves; assert its 40-hex shape instead. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
calesthio
left a comment
There was a problem hiding this comment.
Thank you for refreshing the Qwen model support. I checked the parameter families against the official API reference and ran tests/tools/test_dashscope_image_models.py: 13 passed, with no provider calls. Two integration issues need fixes.
[P2] Include both new generation controls in the cache identity. prompt_extend_mode and enable_thinking reach _build_payload, but neither is in idempotency_key_fields. For model=qwen-image-3.0-pro, a pinned seed and identical prompt, I confirmed that changing thinking or direct to agent leaves idempotency_key() unchanged. With asset caching enabled, a revised generation can restore the prior image. Canonicalize effective generation inputs or include the fields, and add changed-input cache regressions.
[P1] Keep tier-priced cost unknown unless the tier price is established. estimate_cost() returns $0.02 per image for every newly added model/resolution; its comment explicitly calls that a floor, while _generate() returns the same number as cost_usd. A floor cannot support a conservative budget reservation, and it is not a settled charge. Use a verified model/output-tier matrix or PriceQuoteRequired, and keep estimated/unknown spend distinguishable in results. Please test at least the 1k/2k distinction and missing-price path.
5a1a751 to
25a422d
Compare
|
Thanks - both issues are fixed in P2 - cache identity
P1 - tier-priced cost
Tests
No provider calls were made; all tests run against mocked responses. |
…eInc#848) # Conflicts: # docs/PROVIDERS.md
c0c1d74 to
1cba735
Compare
# Conflicts: # docs/PROVIDERS.md
- offer qwen-image-3.0-pro, qwen-image-3.0, qwen-image-2.1-pro, qwen-image-2.1-turbo and qwen-image-2.0 alongside the legacy 2.0 Pro default - gate parameters by generation: negative_prompt is omitted for 2.1, and prompt_extend_mode / enable_thinking / size=auto are only sent to 2.1 and 3.0 - reject unsupported combinations before the API call and expose the parameters actually sent in the result payload - price generations from the published QwenCloud Beijing tariff matrix (1k/2k output tiers, z-image prompt_extend) and bill only the images actually returned; unpriced models or size=auto report cost_usd=None with cost_status="unquoted" - document the model generations, parameter matrix, and tariffs; add unit tests
1cba735 to
42354cc
Compare
Summary
dashscope_imagestill advertises only the Qwen-Image 2.0 generation. Alibaba's Model Studio docs now recommend the 3.0 series (qwen-image-3.0-pro,qwen-image-3.0) and the 2.1 series (qwen-image-2.1-pro,qwen-image-2.1-turbo), and moved the 2.0 series to the legacy pages. This PR adds the current model IDs and gates the parameters that changed between generations.Related issue
Refs #240 (DashScope provider: image gen + TTS + ASR).
Changes
qwen-image-3.0-pro,qwen-image-3.0,qwen-image-2.1-pro,qwen-image-2.1-turbo, andqwen-image-2.0. The default staysqwen-image-2.0-proso existing calls remain byte-compatible.negative_prompt— it is omitted automatically.prompt_extend_mode(direct/agent),enable_thinking, andsize="auto"are sent only to the 2.1 / 3.0 series.enable_thinkingrequiresprompt_extend=true).dashscopeskill; model list and pricing notes indocs/PROVIDERS.md.estimate_cost()uses the published QwenCloud matrix for China North 2 (Beijing) - 1k/2k output-image tiers, plusz-image-turboprompt-extension pricing - and bills only the images actually returned.size="auto"or a model without a published tariff reportscost_usd: Nonewithcost_status: "unquoted".Testing
pytest tests/tools/test_dashscope_image_models.py tests/contracts/test_dashscope_tools.py -q→ 127 passed (after rebasing ontomain)requests.post/requests.getare patched). No live generation call was made; the model IDs and parameter differences come from the Model Studio API reference (updated 2026-10-11).Checklist
make test-contracts/make test) where applicable.