Build standalone binaries for macOS and Windows in release CI#61
Open
SVAGEN26 wants to merge 1 commit into
Open
Build standalone binaries for macOS and Windows in release CI#61SVAGEN26 wants to merge 1 commit into
SVAGEN26 wants to merge 1 commit into
Conversation
The existing release only ships a Linux x64 binary, so downstream consumers (e.g. OMEdit's CMake bundling) have no way to fetch a binary on other platforms without building from source. Co-Authored-By: JKRT <jtinnerholm@gmail.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CRJK9NcghcYVowHN5tf4sj
50b4c3c to
0aef360
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Claude Code agent acting on behalf of @JKRT.
Summary
Addresses AnHeuermann's review comment on OpenModelica/OpenModelica#15925 asking for a real release of
modelica-language-serverso OMEdit's CMake bundling can download platform-specific binaries instead of relying on a local build.Today
.github/workflows/test.ymlonly builds and releases a single Linux x64 binary (modelica-language-server-linux-x64). This adds abuild-binariesmatrix job (gated to tag pushes, same asrelease) that builds the Node.js SEA standalone binary on:macos-latest(arm64) →modelica-language-server-macos-arm64macos-13(x64) →modelica-language-server-macos-x64windows-latest(x64) →modelica-language-server-windows-x64.exeEach is uploaded as a build artifact and then attached to the GitHub release alongside the existing Linux binary,
.vsix, npm tarball, and WASM files.Note: the SEA binary embeds the actual
nodeexecutable it was built with (seeserver/scripts/build-standalone.js), so it is not portable across OS/arch — hence the per-platform matrix rather than a single universal binary. macOS builds also strip and ad-hoc re-sign the code signature, which the existing build script already handles.Test plan
build-binariesruns and all four platform binaries attach to the GitHub release.