Move Aircraft.Fuselage.FORM_FACTOR to premission#1071
Move Aircraft.Fuselage.FORM_FACTOR to premission#1071xjjiang wants to merge 33 commits intoOpenMDAO:mainfrom
Conversation
…se it is set by set_params_for_unit_tests() already.
xjjiang
changed the title
| aircraft:fuselage:delta_diameter,4.5,ft | ||
| aircraft:fuselage:flat_plate_area_increment,0.25,ft**2 | ||
| aircraft:fuselage:form_factor,1.25,unitless | ||
| aircraft:fuselage:form_factor,1.05557953,unitless |
There was a problem hiding this comment.
What did the fuselage form factor change in the csv file? I am guessing that the new value is the value we are calculating now, and the old value was never used because this couldn't be overriden.
In which case, we can probably just take this line out of these csv files, since it is being calculated.
There was a problem hiding this comment.
You are right. Now, I removed this line. There might be other lines that are not used in the models.
There was a problem hiding this comment.
There is no issues anymore. fuselage form factor was missing from AERO_2DOF_INPUTS.
There was a problem hiding this comment.
The line is still here from my view, just double checking it was removed as requested?
jkirk5
left a comment
jkirk5
left a comment
There was a problem hiding this comment.
Ready to approve, just need to check an earlier comment was addressed
| aircraft:fuselage:delta_diameter,4.5,ft | ||
| aircraft:fuselage:flat_plate_area_increment,0.25,ft**2 | ||
| aircraft:fuselage:form_factor,1.25,unitless | ||
| aircraft:fuselage:form_factor,1.05557953,unitless |
There was a problem hiding this comment.
The line is still here from my view, just double checking it was removed as requested?
Removed the form factor entry from the aircraft specifications.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
3 participants
Summary
FormFactorAndSIWBtoFormFactorandSIWB.BWBFormFactorAndSIWBtoBWBFormFactorandBWBSIWB.FormFactorandBWBFormFactorto premission.SIWBandBWBSIWBin mission. Theoretically,SIWBcan be moved to premission, but we would have to create an Aviary variable for it.Related Issues
Backwards incompatibilities
None
New Dependencies
None