Repository navigation
Restore hash coverage and separate SonarCloud analysis - #125
Merged
Merged
Conversation
peter-lawrey-admin
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maven's
sonarprofile preparessurefireArgLine, but the default test execution expands it before JaCoCo runs and the non-compact-string executions use a different property. Both JVM paths therefore run without the agent and silently skip coverage reporting/checking.Use late evaluation of
surefireArgLinefor every unit-test execution. Keep Maven verification in the existingBuildcheck, require its JaCoCo XML to exist, and give SonarCloud analysis its own dependent job consuming the verified classes and coverage artifact. Move the Actions/JDK updates and testing-strategy note out of seed-contract PR #120. No failure is suppressed.Validation on Linux x86-64, OpenJDK 21, Maven 3.9.11, isolated cached dependencies:
mvn -Psonar -Dtest=MurmurHash3Test -X clean verifypasses, but both fork commands lack-javaagentandtarget/jacoco.execis absent.mvn -Psonar -X clean verifypasses two 14,901-case unit executions (5 and 8 skips), plus the automatic-module-name integration test. All 38 unit-test forks receive the JaCoCo agent, including all 19 non-compact-string forks.git diff --checkpasses.The remaining Sonar blocker is now classified as rejection of the configured credential. Run 34697089926 at
88a87c46f293e4dba01cc9bc882207ca9956e060again passes Build and the artifact transfer; the added authentication check receivesvalid: falsefrom SonarCloud forSONAR_TOKENand fails explicitly before scanning. The check sends the credential only to SonarCloud and does not print its value. Job 103523545730 supplies a maskedSONAR_TOKENand fails withNot authorized or project not foundafter successful tests. The public SonarCloud project API confirms projectOpenHFT_Zero-Allocation-Hashingbelongs to organisationopenhft. The available GitHub credential cannot inspect organisation secret metadata (HTTP 403). An administrator must replace or repair the configured credential, confirm its analysis permission for this project, and rerun analysis. Token expiry is not established by this result. Keep this repair draft until analysis succeeds.The property wiring follows JaCoCo's prepare-agent guidance.